fix: Effect Modal Test Effect Aria accessibility#2604
Merged
SReject merged 3 commits intocrowbartools:v5from Jul 11, 2024
CKY-:v5-effect-model-aria-fix
Merged
fix: Effect Modal Test Effect Aria accessibility#2604SReject merged 3 commits intocrowbartools:v5from CKY-:v5-effect-model-aria-fix
SReject merged 3 commits intocrowbartools:v5from
CKY-:v5-effect-model-aria-fix
Conversation
SReject
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
made the test effect button on the effect modal accessible with tab
made the effect menu button on the effect modal accessible with tab
fixing not screen readers not being able to see the buttons.
Applicable Issues
#2600
Testing
used NVDA screen reader to tell me what element i was tabbing into
Screenshots