fix: api/v1/viewers to return proper username and displayName#2607
Merged
SReject merged 1 commit intocrowbartools:v5from Jul 14, 2024
alfw:fix/api-viewers
Merged
fix: api/v1/viewers to return proper username and displayName#2607SReject merged 1 commit intocrowbartools:v5from alfw:fix/api-viewers
api/v1/viewers to return proper username and displayName#2607SReject merged 1 commit intocrowbartools:v5from
alfw:fix/api-viewers
Conversation
SReject
approved these changes
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
With the refactor of username earlier in the year this endpoint was missed. This was returning the displayName as the username / login name on the API. This change may break integrations / projects that use the
api/v1/viewersendpoint where it now will show the login name instead. So this now return the id, username and displayName to still allow integrations / projects to adapt and show ether the displayName or username / login name.Applicable Issues
Related: #2432