Feat: obsIsConnected Replace Variable#2608
Merged
SReject merged 26 commits intocrowbartools:v5from Jul 15, 2024
Merged
Conversation
This is ideally suitable for Text-To-Speech messages and the like. It will filter out any URLs, and any emotes, so only the text from the chat message remains. I also have no clue how to properly get a firebot development environment setup (darn you font awesome, what am I doing wrong?), but it seems to be fully functional on twitch with every scenariou I could throw at it.
Revert "Feat: Add $chatMessageTextOnly variable"
…anity/Firebot into feature/obs-is-connected-var
…t may break style guides and may need to be reverted 😛
This is ideally suitable for Text-To-Speech messages and the like. It will filter out any URLs, and any emotes, so only the text from the chat message remains. I also have no clue how to properly get a firebot development environment setup (darn you font awesome, what am I doing wrong?), but it seems to be fully functional on twitch with every scenariou I could throw at it.
…t may break style guides and may need to be reverted 😛
…anity/Firebot into feature/obs-is-connected-var
SReject
reviewed
Jul 15, 2024
SReject
reviewed
Jul 15, 2024
SReject
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Implementation of the replace variable
obsIsConnectedfor use in conditionals to determine if Firebot should even bother attempting to use OBS-related Events and Websocket Requests without the need of the user to be Recording or Streaming.Applicable Issues
n/a
Testing
Have manually tested this working in a local deploy of Firebot, it's literally just introducing a public getter and a variable interface to an already existing state in
obsRemote, so not much room for weird edge cases where it could fail.Screenshots
n/a