fix: $randomActiveViewer variable filtering#2627
Merged
ebiggz merged 2 commits intocrowbartools:v5from Jul 21, 2024
Merged
Conversation
Also upgraded string vs null parameter type checking to allow the examples to function. Per issue crowbartools#2576
ebiggz
approved these changes
Jul 21, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Nice catch, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Corrects the behavior of the
$randomActiveViewervariable to allow for filtering again, and adds better handling of"null"vs$nullparameters.The issue appears to have originated with 042cc56, when
CustomRolesManager.getRoleByNamemigrated from returning an array of strings to an array of objects.Applicable Issues
#2576
Testing
Pending, TBD.
Screenshots
Not applicable.