feat: Update preset effect list aria item#2642
Merged
ebiggz merged 2 commits intocrowbartools:v5from Jul 28, 2024
CKY-:v5-preset-effect-list-aria
Merged
feat: Update preset effect list aria item#2642ebiggz merged 2 commits intocrowbartools:v5from CKY-:v5-preset-effect-list-aria
ebiggz merged 2 commits intocrowbartools:v5from
CKY-:v5-preset-effect-list-aria
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
adds title to the searchable combo
changes the name of Custom to Custom Effect List
changed the name of Preset to Preset Effect List
so that screen readers can know that Selected: Custom Effect List is selected. or Preset Effect List is selected
Applicable Issues
#2617
Testing
i have used NVDA to verify what is being read out is what is displayed on the screen
Screenshots