fix: Export Setup Components Filter Negation#2643
Merged
ebiggz merged 1 commit intocrowbartools:v5from Jul 28, 2024
Merged
Conversation
phroggster
force-pushed
the
fix_setup_filtering_negation
branch
from
bccc199 to
d13f798
Compare
Angular will negate filters that start with an exclamation mark, which is cool. However, many commands start with an exclamation mark, so the negation behavior is undesired here. Also cleaned up a trivial arrow-parens lint warning.
phroggster
force-pushed
the
fix_setup_filtering_negation
branch
from
d13f798 to
f9ef09b
Compare
Collaborator
Author
|
I love how I can rebase a PR (edit: on the web) to get it up to the HEAD of the base, but can't pull that commit back down locally. Sigh. |
ebiggz
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Applicable Issues
None applicable
Testing
Tried a number of things to break it, but I think even this one will get past CK.
Screenshots
Screenshot showing searching for (in clockwise order):