Skip to content

Fix: manual metadata null values for strings#2648

Merged
SReject merged 1 commit intocrowbartools:v5from
CKY-:v5
Jul 31, 2024
Merged

Fix: manual metadata null values for strings#2648
SReject merged 1 commit intocrowbartools:v5from
CKY-:v5

Conversation

@CKY-
Copy link
Collaborator

@CKY- CKY- commented Jul 30, 2024

Co-authored-by: DennisRijsdijk dennisrijsdijk@users.noreply.github.com

Description of the Change

some scripts would try to use null as a manualMetadata
resulting in error

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'type')
    at simulateGroupEventsModal.js:101:71
    at Array.map (<anonymous>)
    at $ctrl.eventChanged (simulateGroupEventsModal.js:97:82)

image

this change trys to help alleviate that but will fail with nulled type objects

image

as illustrated in this screenshot campaign info is empty
and to be clear i do not have tiltify configured so that may change

Applicable Issues

#2647

Testing

this was loaded with the tiltafy script and tested as its the only offended script that could be found

Screenshots

Co-authored-by: DennisRijsdijk <dennisrijsdijk@users.noreply.github.com>
@CKY- CKY- requested a review from ebiggz as a code owner July 30, 2024 20:13
@SReject SReject merged commit 4cd2954 into crowbartools:v5 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments