Fix: manual metadata null values for strings#2648
Merged
SReject merged 1 commit intocrowbartools:v5from Jul 31, 2024
CKY-:v5
Merged
Fix: manual metadata null values for strings#2648SReject merged 1 commit intocrowbartools:v5from CKY-:v5
SReject merged 1 commit intocrowbartools:v5from
CKY-:v5
Conversation
Co-authored-by: DennisRijsdijk <dennisrijsdijk@users.noreply.github.com>
SReject
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: DennisRijsdijk dennisrijsdijk@users.noreply.github.com
Description of the Change
some scripts would try to use null as a manualMetadata
resulting in error
this change trys to help alleviate that but will fail with nulled type objects
as illustrated in this screenshot campaign info is empty
and to be clear i do not have tiltify configured so that may change
Applicable Issues
#2647
Testing
this was loaded with the tiltafy script and tested as its the only offended script that could be found
Screenshots