fix: $chatMessageTextOnly Wash, Wax, and Polish#2649
Merged
SReject merged 2 commits intocrowbartools:v5from Jul 31, 2024
Merged
fix: $chatMessageTextOnly Wash, Wax, and Polish#2649SReject merged 2 commits intocrowbartools:v5from
SReject merged 2 commits intocrowbartools:v5from
Conversation
This addresses a couple of rough edges in $chatMessageTextOnly: - Adds command trigger removal by default. - Better trims white space everywhere it touches (but not within text parts that include it!) - Adds examples showing what the variable can do. - Unicode emoji will still get through. This only removes: twitch emotes, third-party emotes, cheermotes, and URLs.
phroggster
force-pushed
the
chatMessageTextOnly_seasoned
branch
from
7472063 to
d9a4f12
Compare
SReject
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Addresses a couple of rough edges in
$chatMessageTextOnly:Applicable Issues
N/A
Testing
Yes. CKY will still likely have an esoteric regex trigger that could behave unexpectedly, however.
Screenshots
N/A