Feature/obs animate transform#2664
Conversation
…eanity/Firebot into feature/obs-animate-transform
ebiggz
left a comment
There was a problem hiding this comment.
I really appreciate how clean and easy to read your code is. I only have a couple of relatively minor suggestions for maintainability.
This is awesome though and I think users are going to have a lot of fun with it!
src/backend/integrations/builtin/obs/effects/transform-obs-source-scale.ts
Outdated
Show resolved
Hide resolved
src/backend/integrations/builtin/obs/effects/transform-obs-source-scale.ts
Outdated
Show resolved
Hide resolved
src/backend/integrations/builtin/obs/effects/transform-obs-source-scale.ts
Outdated
Show resolved
Hide resolved
src/backend/integrations/builtin/obs/effects/transform-obs-source-scale.ts
Show resolved
Hide resolved
…eanity/Firebot into feature/obs-animate-transform
…up array pushes in `getLerpedCallsArray`
|
Added comment to techdebt the generic-ifying of the |
|
Also made some MINOR changes to the function itself, noticed a few unwanted behaviors, but it seems clean now 😎 Now if |
ebiggz
left a comment
There was a problem hiding this comment.
Looking fantastic, thanks for all the time and effort you put into this!
Description of the Change
This implements a new Effect,
Transform OBS Source, that allows users to perform animated transforms to a source's Position, Scale or RotationApplicable Issues
#2635
Testing
Have done fairly comprehensive testing of all fields and combination of fields, but would like another person to smoke test it in case I missed edge cases
Screenshots
n/a