Skip to content

Feature/obs animate transform#2664

Merged
ebiggz merged 28 commits intocrowbartools:v5from
Oceanity:feature/obs-animate-transform
Aug 14, 2024
Merged

Feature/obs animate transform#2664
ebiggz merged 28 commits intocrowbartools:v5from
Oceanity:feature/obs-animate-transform

Conversation

@Oceanity
Copy link
Contributor

@Oceanity Oceanity commented Aug 4, 2024

Description of the Change

This implements a new Effect, Transform OBS Source, that allows users to perform animated transforms to a source's Position, Scale or Rotation

Applicable Issues

#2635

Testing

Have done fairly comprehensive testing of all fields and combination of fields, but would like another person to smoke test it in case I missed edge cases

Screenshots

n/a

@Oceanity Oceanity requested a review from ebiggz as a code owner August 4, 2024 18:50
Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate how clean and easy to read your code is. I only have a couple of relatively minor suggestions for maintainability.

This is awesome though and I think users are going to have a lot of fun with it!

@Oceanity
Copy link
Contributor Author

Oceanity commented Aug 7, 2024

Added comment to techdebt the generic-ifying of the getLerpedCallsArray method, will contemplate some possible paths forward on that in the near future

@Oceanity
Copy link
Contributor Author

Oceanity commented Aug 7, 2024

Also made some MINOR changes to the function itself, noticed a few unwanted behaviors, but it seems clean now 😎

Now if duration is 0 or undefined, it will just instantly transform the source to the end transform, or start transform if end is not provided

Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fantastic, thanks for all the time and effort you put into this!

@ebiggz ebiggz merged commit 99d7846 into crowbartools:v5 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments