feat (effect): add activity feed effect#2667
Merged
ebiggz merged 7 commits intocrowbartools:v5from Aug 6, 2024
CKY-:v5-Activity-Feed-Effect
Merged
feat (effect): add activity feed effect#2667ebiggz merged 7 commits intocrowbartools:v5from CKY-:v5-Activity-Feed-Effect
ebiggz merged 7 commits intocrowbartools:v5from
CKY-:v5-Activity-Feed-Effect
Conversation
phroggster
reviewed
Aug 5, 2024
Collaborator
phroggster
left a comment
phroggster
left a comment
There was a problem hiding this comment.
Couple of minor things worth poking
ebiggz
requested changes
Aug 6, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Thanks so much for working on this!
Couple feedback items to tighten things up and set us up better in the future. Should be good to go after that!
I know you are taking a break at the moment so if you'd prefer that I go ahead and apply these tweaks, just ping or DM me in Discord 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
this effect adds the ability to create entries in the activity feed.
this change Required UUID Types so that was added in the package it is working but not sure if version 10.0.0 is too new?
im unsure if the package lock is needed.
Applicable Issues
#2634
Testing
added effect to preset list and changed the icon added text then clicked play
added effect to preset list left icon empty and added text then clicked play as noted in the screenshots
Screenshots