Skip to content

Comments

feat: OBS Color Picker, Raw/Variable Color Entry#2708

Merged
ebiggz merged 6 commits intocrowbartools:v5from
dennisrijsdijk:fix-feat/obs-source-color
Aug 18, 2024
Merged

feat: OBS Color Picker, Raw/Variable Color Entry#2708
ebiggz merged 6 commits intocrowbartools:v5from
dennisrijsdijk:fix-feat/obs-source-color

Conversation

@dennisrijsdijk
Copy link
Collaborator

Description of the Change

fixed an issue where RGB-only color codes in the OBS Color Source Effect didn't get padded for transparency, thus getting transparency: 0 from OBS
Added a color picker for OBS Color Source Effect that allows users to pick a color with alpha
Added a custom color mode that allows for replace variables that result in ARGB hex codes

Applicable Issues

partially resolves #2250

Testing

Ensured pre-existing effects (saved as ARGB) show their appropriate color, both with and without saving from effect settings UI

Ensured pre-existing effects switch to Custom Color mode when entering effect settings UI

Ensured new effects start in color picker mode with a default color

Ensured ARGB -> RGBA conversion only happens when alpha portion is present and input is a valid hex code

Ensured only valid color codes can be saved when custom mode is turned off

Context

Due to technical limitations in the angularjs-color-picker component, the custom entry (ARGB) and color picker (RGBA) differ in color formats. I have added labels to indicate this as clearly as possible in order to forego some of the confusion.

When switching modes, Firebot will convert the color code as long as it's a valid ARGB or RGBA color code (depending on mode switch)

Screenshots

image
image
image
image

@dennisrijsdijk dennisrijsdijk requested a review from ebiggz as a code owner August 18, 2024 11:47
@ebiggz ebiggz enabled auto-merge (squash) August 18, 2024 17:20
@ebiggz ebiggz merged commit e792bca into crowbartools:v5 Aug 18, 2024
@dennisrijsdijk dennisrijsdijk deleted the fix-feat/obs-source-color branch August 18, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants