feat: OBS Color Picker, Raw/Variable Color Entry#2708
Merged
ebiggz merged 6 commits intocrowbartools:v5from Aug 18, 2024
Merged
feat: OBS Color Picker, Raw/Variable Color Entry#2708ebiggz merged 6 commits intocrowbartools:v5from
ebiggz merged 6 commits intocrowbartools:v5from
Conversation
ebiggz
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
fixed an issue where RGB-only color codes in the OBS Color Source Effect didn't get padded for transparency, thus getting transparency: 0 from OBS
Added a color picker for OBS Color Source Effect that allows users to pick a color with alpha
Added a custom color mode that allows for replace variables that result in ARGB hex codes
Applicable Issues
partially resolves #2250
$obsColorValuewill invert the color as it was meant for raw requests. [Feature Request] Color variable #2076 may provide a solution here.Testing
Ensured pre-existing effects (saved as ARGB) show their appropriate color, both with and without saving from effect settings UI
Ensured pre-existing effects switch to Custom Color mode when entering effect settings UI
Ensured new effects start in color picker mode with a default color
Ensured ARGB -> RGBA conversion only happens when alpha portion is present and input is a valid hex code
Ensured only valid color codes can be saved when custom mode is turned off
Context
Due to technical limitations in the angularjs-color-picker component, the custom entry (ARGB) and color picker (RGBA) differ in color formats. I have added labels to indicate this as clearly as possible in order to forego some of the confusion.
When switching modes, Firebot will convert the color code as long as it's a valid ARGB or RGBA color code (depending on mode switch)
Screenshots