fix: Move clips to iframe#2778
Merged
ebiggz merged 3 commits intocrowbartools:v5from Sep 11, 2024
CKY-:v5-clip-iframe
Merged
Conversation
ebiggz
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
move clips to use twitchs iFrame.
Applicable Issues
#2768
Testing
tested clip playback in the overlay.
clips will now be gated by CCL ContentDisplayPreferences
if streamers would like the gated video to play they will need to interact in the browser object and allow it for the first time. obs then "should" save the choice as a cookie object.
this is out of our control and we do not receive the CCL in the clip endpont data.
this will not be affected by the https://www.twitch.tv/settings/content-preferences that is unless the browser source is logged in to twitch in the browser source.
Screenshots