fix: $hasRole and $hasRoles Usage Examples#2790
Merged
ebiggz merged 6 commits intocrowbartools:v5from Sep 13, 2024
Merged
Conversation
- Role name comparisons are case-sensitive. - Moderator and VIP being the names sent out. - So reflect those accurately in the examples. - ... and clear up a few lint warnings (white space, ignored param)
ebiggz
approved these changes
Sep 13, 2024
Member
ebiggz
left a comment
ebiggz
left a comment
There was a problem hiding this comment.
Oh wow nice find on the incorrect usages. Looks good 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes usage examples for
$hasRolesand adds examples for$hasRole.Applicable Issues
Discord #questions thread: give VIP or Mod role based on metadata?
Testing
Minimal
Screenshots