Skip to content

Comments

feat: add a user allow list to the moderation tool#2983

Merged
CaveMobster merged 8 commits intov5from
feature/url-modding-user-whitelist
Feb 17, 2025
Merged

feat: add a user allow list to the moderation tool#2983
CaveMobster merged 8 commits intov5from
feature/url-modding-user-whitelist

Conversation

@CaveMobster
Copy link
Member

@CaveMobster CaveMobster commented Feb 9, 2025

Description of the Change

Adds an allowlist for users in addition to the url allowlist. This is technically also solved by making a custom group and adding that custom group to the exempt list, but this is mostly meant for people who want to have a very simple setup.

Applicable Issues

n/a

Testing

Tested if people are or aren't allowed to post urls, adding and removing names as well as removing all of them at once.

Screenshots

image

@CaveMobster CaveMobster requested a review from ebiggz as a code owner February 9, 2025 10:17
@dennisrijsdijk
Copy link
Collaborator

Would it make more sense for the allowed users to use the viewer-search-modal instead, and store users by id + username? We get the userId in all chat related events so consuming it is no issue, and storing by id instead would allow more safety in the case of someone changing their username (eg. I permit account A. Account A changes its username. Account A can no longer post URLs. After Twitch releases the old name, Account B registers that name, and now gains the ability to post URLs)

@CaveMobster
Copy link
Member Author

CaveMobster commented Feb 9, 2025

Would it make more sense for the allowed users to use the viewer-search-modal instead, and store users by id + username? We get the userId in all chat related events so consuming it is no issue, and storing by id instead would allow more safety in the case of someone changing their username (eg. I permit account A. Account A changes its username. Account A can no longer post URLs. After Twitch releases the old name, Account B registers that name, and now gains the ability to post URLs)

Ah yes, that's a good point, thank you @dennisrijsdijk! I'm gonna look into that.

@CaveMobster CaveMobster marked this pull request as draft February 9, 2025 10:43
@CaveMobster CaveMobster marked this pull request as ready for review February 11, 2025 12:33
Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love the return of Cave PRs too!

@ebiggz ebiggz changed the title Add a user allow list to the moderation tool feat: add a user allow list to the moderation tool Feb 17, 2025
@CaveMobster CaveMobster merged commit 23b60e7 into v5 Feb 17, 2025
1 check passed
@CaveMobster CaveMobster deleted the feature/url-modding-user-whitelist branch February 17, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants