feat(variables): Overlay-Resources folder variable. (#2988)#3007
Merged
ebiggz merged 1 commit intocrowbartools:v5from Feb 20, 2025
Merged
feat(variables): Overlay-Resources folder variable. (#2988)#3007ebiggz merged 1 commit intocrowbartools:v5from
ebiggz merged 1 commit intocrowbartools:v5from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
add a variable to get the system path of the overlay-resources path
allow traversal of array of paths to be used in play video, play sound, show image and obs;s path effects.
Applicable Issues
#2988
Testing
$overlayResourcesPath/audio/ding.wav
$overlayResourcesPath[audio, ding.wav]
$overlayResourcesPath[audio/ding.wav]
slash oriantiation dont matter on windows but could be affected on other systems
both return
"C:\Users\cky\AppData\Roaming\Firebot\v5\overlay-resources\audio/ding.wav"
path.resolve is um dumb and allows you to go where you should not
$overlayResourcesPath[/etc/passwd]
n
Screenshots