This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Plat-14318 remove cli #1122
Merged
Plat-14318 remove cli #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metalheart88
previously approved these changes
Apr 10, 2024
README.md
Outdated
Comment on lines
33
to
35
| - [python](https://www.python.org/) | ||
| - [pipenv](https://pypi.org/project/pipenv/) | ||
| - [urllib3](https://urllib3.readthedocs.io/en/stable/) without this the project will not run in ```macOS``` environments | ||
| - [urllib3](https://urllib3.readthedocs.io/en/stable/) without this the project will not run in `macOS` environments |
Collaborator
There was a problem hiding this comment.
Those are cli requirements, we should mention that one must install the cli and its requirements and just link to crowdbotics/cli repo
danielsousaio
previously approved these changes
Apr 10, 2024
Collaborator
danielsousaio
left a comment
danielsousaio
left a comment
There was a problem hiding this comment.
Looks good, just a minor thing on the readme
taylor-cb
dismissed stale reviews from danielsousaio and Metalheart88
via
31b87a6
Metalheart88
previously approved these changes
Apr 10, 2024
robester0403
approved these changes
Apr 10, 2024
alaisgomes
previously approved these changes
May 9, 2025
Metalheart88
previously approved these changes
May 9, 2025
alaisgomes
previously approved these changes
May 9, 2025
Metalheart88
previously approved these changes
May 9, 2025
alaisgomes
approved these changes
May 9, 2025
Metalheart88
approved these changes
May 9, 2025
Contributor
|
The IOS/Android CI seems like it is testing nothing? It's supposed to test the scaffold, which is a completely repo now: https://github.com/crowdbotics/react-native-scaffold |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Plat-14318
Related tickets:
Related PRs:
Type of PR
Did you make changes to modules or created a new module?
Changes introduced
Removing CLI from modules repo, as it's now been moved to https://github.com/crowdbotics/cli