Skip to content

Conversation

@hriteshMaikap
Copy link
Contributor

I have refered to a similar issue and tried to update the required paramter in the intended functions.

@hriteshMaikap hriteshMaikap changed the title Added the new parameter taskId in the List Strings feat: Added the new parameter taskId in the List Strings Oct 29, 2024
@andrii-bodnar andrii-bodnar linked an issue Oct 30, 2024 that may be closed by this pull request
@hriteshMaikap
Copy link
Contributor Author

I have made the changes in the source_strings folder and updated the list_strings function.
Corresponding to this, I have made the chnages in test_list_strings function. Please let me know if this is up to the mark.

@andrii-bodnar
Copy link
Member

@hriteshMaikap Unit tests are failing - https://github.com/crowdin/crowdin-api-client-python/actions/runs/11591334833/job/32272134877?pr=179

Please take a look

@hriteshMaikap
Copy link
Contributor Author

@hriteshMaikap Unit tests are failing - https://github.com/crowdin/crowdin-api-client-python/actions/runs/11591334833/job/32272134877?pr=179

Please take a look

I have updated the paramter from test_list_strings, because they were being used in other test functions as well. I know this is quote a simple issue, but this is the first time i am updating code that has to pass workflows. So some help from you in case of failure of test cases again can help me learn.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (87e0122) to head (582eb89).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         166      166           
  Lines        6497     6497           
  Branches      149      149           
=======================================
  Hits         6445     6445           
  Misses         36       36           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hriteshMaikap thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add taskId parameter support to the List Strings API endpoint

3 participants