-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Added the new parameter taskId in the List Strings
#179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
taskId in the List Strings taskId in the List Strings
|
I have made the changes in the source_strings folder and updated the list_strings function. |
|
@hriteshMaikap Unit tests are failing - https://github.com/crowdin/crowdin-api-client-python/actions/runs/11591334833/job/32272134877?pr=179 Please take a look |
I have updated the paramter from test_list_strings, because they were being used in other test functions as well. I know this is quote a simple issue, but this is the first time i am updating code that has to pass workflows. So some help from you in case of failure of test cases again can help me learn. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 166 166
Lines 6497 6497
Branches 149 149
=======================================
Hits 6445 6445
Misses 36 36
Partials 16 16 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hriteshMaikap thank you!
I have refered to a similar issue and tried to update the required paramter in the intended functions.