Skip to content

Appsec unix socket#2737

Merged
LaurenceJJones merged 6 commits intocrowdsecurity:masterfrom
LaurenceJJones:appsec_socket
Feb 21, 2024
Merged

Appsec unix socket#2737
LaurenceJJones merged 6 commits intocrowdsecurity:masterfrom
LaurenceJJones:appsec_socket

Conversation

@LaurenceJJones
Copy link
Copy Markdown
Contributor

@LaurenceJJones LaurenceJJones commented Jan 14, 2024

Allowing creating unix appsec socket and have ability to run both at same time incase you have local http and remote 🤷🏻

cs Lua integration PR

Good read if you want to know why unix sockets should be an option to improve performance

@github-actions
Copy link
Copy Markdown

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link
Copy Markdown

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Copy Markdown
Contributor Author

/kind enhancement
/area agent

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (e976614) 57.91% compared to head (4342c7b) 57.88%.

Files Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   57.91%   57.88%   -0.04%     
==========================================
  Files         239      239              
  Lines       31005    31028      +23     
==========================================
+ Hits        17958    17961       +3     
- Misses      11413    11434      +21     
+ Partials     1634     1633       -1     
Flag Coverage Δ
bats 37.87% <0.00%> (-0.02%) ⬇️
unit-linux 52.28% <0.00%> (-0.06%) ⬇️
unit-windows 47.74% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buixor buixor added this to the 1.6.1 milestone Feb 2, 2024
@buixor buixor requested a review from mmetc February 2, 2024 13:46
@LaurenceJJones LaurenceJJones merged commit f3ea88f into crowdsecurity:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants