Improve OCSP error logging #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robstradling
left a comment
robstradling
left a comment
There was a problem hiding this comment.
I've committed an alternative fix: 2db360b
| der_cert, err := base64.StdEncoding.DecodeString(b64_cert) | ||
| if err != nil { | ||
| return fmt.Sprintf("%v", err) | ||
| return fmt.Sprintf("Error while base64 decoding EE cert|%v", err) |
Member
There was a problem hiding this comment.
This function (Ocsp_check) isn't only used to perform OCSP checks for EE certs.
| der_issuer, err := base64.StdEncoding.DecodeString(b64_issuer) | ||
| if err != nil { | ||
| return fmt.Sprintf("%v", err) | ||
| return fmt.Sprintf("Error while base64 decoding ICA cert|%v", err) |
Member
There was a problem hiding this comment.
The issue cert isn't necessarily an intermediate. It might be a root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in crtsh/certwatch_db#79 it would be admirable to have a more verbose error logging while doing OCSP checks