compat: Accept name= kwarg in _ModelStub.save#29
Open
romil93 wants to merge 1 commit into
Open
Conversation
HF transformers' fast tokenizer shims (qwen2/qwen3/bart/bloom/codegen/gpt_neox/ electra/deberta/mvp/herbert/lxmert/layoutlm/markuplm/clip/led/...) call `self._tokenizer.model.save(save_directory, name=filename_prefix)` inside save_vocabulary. The previous stub only accepted prefix=, so any PreTrainedTokenizerFast.save_pretrained() call under fastokens.patch_transformers crashed with TypeError at the first checkpoint save. Accept both name= and prefix= for forward/backward compatibility (upstream tokenizers .pyi documents prefix; transformers source uses name); raise TypeError if both are passed with conflicting values. Also update repo URLs (Cargo.toml + README) from the old atero-ai/fast-tokens path to the current crusoecloud/fastokens location, and bump 0.1.2 -> 0.1.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HF transformers' fast tokenizer shims (qwen2/qwen3/bart/bloom/codegen/gpt_neox/ electra/deberta/mvp/herbert/lxmert/layoutlm/markuplm/clip/led/...) call
self._tokenizer.model.save(save_directory, name=filename_prefix)inside save_vocabulary. The previous stub only accepted prefix=, so any PreTrainedTokenizerFast.save_pretrained() call under fastokens.patch_transformers crashed with TypeError at the first checkpoint save.Example references - https://github.com/huggingface/transformers/blob/v4.57.6/src/transformers/models/qwen2/tokenization_qwen2_fast.py#L133
Accept both name= and prefix= for forward/backward compatibility (upstream tokenizers .pyi documents prefix; transformers source uses name); raise TypeError if both are passed with conflicting values.
Also update repo URLs (Cargo.toml + README) from the old atero-ai/fast-tokens path to the current crusoecloud/fastokens location, and bump 0.1.2 -> 0.1.3.