Conversation
Member
|
Yes! This was definitely needed @radiovisual I think a sprite would be the best next improvement that we could offer in a form of a css lib (with cdn, or locally stored). For this library, we should do exactly as you proposed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brh55
This is my initial attempt to close #1, where the new build process saves the images for each icon to the
/imagesdirectory after we get the updated currency list.Its not a perfect solution, but it is a start. The images are named after the currency symbol, so technically, someone could use the symbol name to easily look up the image inside the images directory.
Check it out and let me know what you think.
The images are about 100 Mb as-is, so if we wanted to include images into the .json file, we could run the images through a scaling function that make 60x60 icons, or 24x24 icons, and saves a base64 encoding or shares a url, [and/]or, if we wanted to get crazy ambitious we could automate the building and mapping of a sprite sheet with a CSS and JSON file that has the coordinates necessary to navigate the sprite sheet.
This PR also enhances the terminal output with some useful information: