Skip to content

Save Image Icons#6

Merged
brh55 merged 4 commits intomasterfrom
images
Jan 12, 2018
Merged

Save Image Icons#6
brh55 merged 4 commits intomasterfrom
images

Conversation

@radiovisual
Copy link
Copy Markdown
Member

@radiovisual radiovisual commented Jan 11, 2018

@brh55

This is my initial attempt to close #1, where the new build process saves the images for each icon to the /images directory after we get the updated currency list.

Its not a perfect solution, but it is a start. The images are named after the currency symbol, so technically, someone could use the symbol name to easily look up the image inside the images directory.

Check it out and let me know what you think.

The images are about 100 Mb as-is, so if we wanted to include images into the .json file, we could run the images through a scaling function that make 60x60 icons, or 24x24 icons, and saves a base64 encoding or shares a url, [and/]or, if we wanted to get crazy ambitious we could automate the building and mapping of a sprite sheet with a CSS and JSON file that has the coordinates necessary to navigate the sprite sheet.

This PR also enhances the terminal output with some useful information:

image

@radiovisual radiovisual changed the title Images Save Images Icons Jan 11, 2018
@radiovisual radiovisual changed the title Save Images Icons Save Image Icons Jan 11, 2018
@brh55
Copy link
Copy Markdown
Member

brh55 commented Jan 12, 2018

Yes! This was definitely needed @radiovisual

I think a sprite would be the best next improvement that we could offer in a form of a css lib (with cdn, or locally stored).

For this library, we should do exactly as you proposed

  • scale images: 60x60 icons, or 24x24 icons, and saves a base64 encoding
  • possibly link the hosted images from this github repository (not sure if this is against terms of service)

@brh55 brh55 merged commit 5c8933d into master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Find ways to get the coin icons

2 participants