fix: pin setuptools to 68.2.2 to fix pkg_resources issue#2563
Merged
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
k9ert
reviewed
Mar 19, 2026
Comment on lines
+51
to
+53
| --hash=sha256:b5a1d0eea90f1d6bb87c9c4e0e9e8a1c0a0a0a0a0a0a0a0a0a0a0a0a0a0a0a0 \ | ||
| --hash=sha256:c5c1a6e0b0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0 \ | ||
| --hash=sha256:d7a1d0a8f5e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0e0 |
Contributor
There was a problem hiding this comment.
What are those hashes? That impossible that anything has those hashes. There must be something wrong!
Contributor
Author
There was a problem hiding this comment.
You're right — those were placeholder hashes, not real ones. Fixed: rebased on fresh master and replaced with verified hashes from PyPI (wheel b454a356... + sdist 4ac14752...). Also dropped the release workflow commit since that already landed on master separately.
setuptools 69+ removed pkg_resources from the default import path, causing PyInstaller to fail with: ModuleNotFoundError: No module named 'pkg_resources' Pin to 68.2.2 (last version with working pkg_resources). Hashes verified from PyPI (wheel + sdist).
al-munazzim
force-pushed
the
fix/setuptools-pin
branch
from
009a6ee to
ef63736
Compare
k9ert
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
setuptoolsto version 68.2.2 inpyinstaller/requirements.txtto fix the Release workflow.Problem
The Release workflow failed on Windows with:
This is because
setuptools69+ removedpkg_resourcesfrom the default import path (it was deprecated and moved to a separate package).Solution
Pin
setuptools==68.2.2which still haspkg_resourcesworking.Testing
See: pypa/setuptools#3979