Fix CPU hogging when running in background.#36
Merged
Conversation
Using "System.in.read()" to block the main thread only works if the application is running in the foreground (user provides stdin). If running in background or if stdin is otherwise not blocking this causes 100% cpu usage. Fix by blocking the main thread infinitely with a condition variable. This retains the old functionality (CTRL-C still works to quit the application).
Member
|
While not the most elegant solution, certainly a pragmatic approach. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using "System.in.read()" to block the main thread only works if the
application is running in the foreground (user provides stdin). If
running in background or if stdin is otherwise not blocking this causes
100% cpu usage.
Fix by blocking the main thread infinitely with a condition variable.
This retains the old functionality (CTRL-C still works to quit the
application).
Fixes #35