Skip to content

Allow None vram_total_gb in test_gpu.py snapshot test #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptopoly merged 1 commit into from
May 1, 2026
+7 −3
Merged

Allow None vram_total_gb in test_gpu.py snapshot test #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/test_gpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@ def test_snapshot_gpu_name_is_string(self):
snapshot = monitor.snapshot()
self.assertIsInstance(snapshot["gpu_name"], str)

def test_snapshot_vram_values_are_numeric(self):
def test_snapshot_vram_values_are_numeric_or_none(self):
# ``None`` is a valid response when neither torch.cuda nor
# nvidia-smi can answer — we deliberately don't fall back to
# system RAM via psutil any more (would mislead the safety
# estimator). Numeric otherwise.
monitor = GPUMonitor()
snapshot = monitor.snapshot()
self.assertIsInstance(snapshot["vram_total_gb"], (int, float))
self.assertIsInstance(snapshot["vram_used_gb"], (int, float))
self.assertIsInstance(snapshot["vram_total_gb"], (int, float, type(None)))
self.assertIsInstance(snapshot["vram_used_gb"], (int, float, type(None)))


class GPUMonitorNvidiaTests(unittest.TestCase):
Expand Down