Test vectors #22
Merged
Test vectors #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbride
force-pushed
the
p2qrh
branch
3 times, most recently
from
aa85409 to
32cf0bd
Compare
Owner
|
Looks like the typo checks are failing. Let's also be sure to get the python test vectors. And finally, we'll need to update the BIP Test vectors section to provide an overview similar to this section of BIP-341: |
jbride
force-pushed
the
p2qrh
branch
6 times, most recently
from
4afd812 to
478ebf1
Compare
jbride
force-pushed
the
p2qrh
branch
2 times, most recently
from
967fde7 to
06c2103
Compare
P2QRHScriptBuf.new_p2qrh(...) function is generating a scriptPubKey value with with back-to-back duplicate OP_PUSHBYTES_32 opcode. #6 jbride/rust-bitcoin#1
performance and failure tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2qrh test vectors and documentation