Skip to content

Conversation

@smonicas
Copy link
Collaborator

@smonicas smonicas commented May 9, 2023

Etherscan now returns the following error message when rate limit is reached "Max rate limit reached, please use API Key for higher rate limit".
https://docs.etherscan.io/support/common-error-messages#max-rate-limit
At the moment when rate limit is reached an incorrect error message is returned.

Closes #233

@montyly
Copy link
Contributor

montyly commented May 9, 2023

Maybe we can compare with "rate limit reached" in info["result"].lower() instead? It should be more robust against further changes

Might be worth to compare info["result"]'s type also

@montyly montyly merged commit ba938fc into dev May 16, 2023
@montyly montyly deleted the dev-etherscan-rate-limit branch May 16, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants