platform: etherscan: add support for solc remaps, evm version #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for solc remaps found in the Etherscan JSON. Fixes: #415
elopez
force-pushed
the
fix-etherscan-remappings
branch
from
e739787 to
4aa13a1
Compare
elopez
force-pushed
the
fix-etherscan-remappings
branch
from
aa7af41 to
7da2761
Compare
Contributor
Member
Author
|
This also seems to fix the case in #386. The case in #151 requires passing the EVM target, which this PR doesn't, but it could be added as a follow up. #150:
we could override any absolute paths and make them relative though, that would work in this case from what I can see.
|
elopez
force-pushed
the
fix-etherscan-remappings
branch
from
f61ef40 to
fa4cd58
Compare
elopez
changed the title
elopez
force-pushed
the
fix-etherscan-remappings
branch
2 times, most recently
from
1aa03fc to
21b1f59
Compare
Member
Author
|
I added some more code to handle those two cases 👍 |
This was
linked to
issues
Jun 9, 2023
is_absolute() will return False on Windows if a Path does not contain a drive letter (e.g. if you are using a POSIX path string) solc on Windows does not seem to like case #5 though, so mark it as expected to fail.
elopez
force-pushed
the
fix-etherscan-remappings
branch
from
21b1f59 to
fec9713
Compare
0xalpharush
reviewed
Jun 12, 2023
Comment on lines
+479
to
+481
| if os.path.commonpath((allowed_path, os.path.abspath(dest_disk))) != allowed_path: | ||
| LOGGER.warning("Remapping %s=%s is potentially unsafe, skipping", origin, dest) | ||
| continue |
Contributor
There was a problem hiding this comment.
Not blocking but we should extract this into utils so we can have a common API to validate absolute path resolution (ref 8a7c037)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for solc remaps and EVM version found in the Etherscan JSON.
Fixes #150, #151, #386, #415