Skip to content

SolcStandardJson: pass solc_env and solc_working_dir through to compilation #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
montyly merged 3 commits into from
Apr 13, 2024
Merged

SolcStandardJson: pass solc_env and solc_working_dir through to compilation #514

montyly merged 3 commits into from
Apr 13, 2024

Conversation

@garythung
Copy link
Contributor

@garythung garythung commented Nov 1, 2023 •
edited
Loading

  • Adds an optional kwarg to the SolcStandardJson platform so you can specify the solc version. Otherwise, it runs whichever solc version is currently active.
  • pass the solc_working_dir variable through to compilation

@CLAassistant
Copy link

CLAassistant commented Nov 1, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@garythung garythung changed the title add solc env field for solc standard json SolcStandardJson: pass solc_env and solc_working_dir through to compilation Nov 1, 2023
@montyly montyly changed the base branch from master to dev April 13, 2024 13:46
@montyly
Copy link
Contributor

montyly commented Apr 13, 2024

This is great, thanks @garythung

@montyly montyly added this pull request to the merge queue Apr 13, 2024
Merged via the queue into crytic:dev with commit 59b2b75 Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush

@bohendo bohendo Awaiting requested review from bohendo bohendo is a code owner

1 more reviewer

@montyly montyly montyly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garythung @CLAassistant @montyly