-
Notifications
You must be signed in to change notification settings - Fork 21
V9 #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cs-util, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several beneficial updates to the AGENTS.md documentation, enhancing clarity around the development workflow, testing practices, and dependency management. The changes effectively promote a more disciplined and iterative approach. I've added a couple of minor suggestions to further improve the readability and precision of the new guidelines.
| - Preserve existing comments & docs; add concise, long-lived comments where useful and avoid narrating changes via comments | ||
| - When external documentation could be consulted, do so to validate your plan makes sense. If you lack a browsing/online search tool, ask the user to run an online search for you (e.g., "Please search for \"x\" and paste back the findings") | ||
| - Before adding functionality, search the codebase (e.g., ripgrep) to confirm it's truly absent. If present, prefer refactor over re-implementation. | ||
| - After each iteration add a concise update at the end of docs/implementation-progress.md to use it as the memory between iterations for learnings, decisions, planning etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of "etc." at the end of the sentence is a bit vague. For improved clarity and to ensure the instruction is as precise as possible, it's better to list the expected items explicitly or rephrase to avoid ambiguity.
| - After each iteration add a concise update at the end of docs/implementation-progress.md to use it as the memory between iterations for learnings, decisions, planning etc. | |
| - After each iteration add a concise update at the end of docs/implementation-progress.md to use it as the memory between iterations for learnings, decisions, and planning. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This pull request updates the
AGENTS.mddocumentation to clarify and strengthen the development workflow, especially around test-driven development (TDD), dependency management, and documentation practices. The changes emphasize a more disciplined, iterative approach and add guidance to improve maintainability and knowledge sharing.Development workflow improvements:
npm testbefore and after any change.docs/implementation-progress.mdafter each iteration to track decisions and learning across iterations.Testing practices:
Dependency management:
npm outdatedweekly (instead of before and after every task), but still require runningnpm testbefore and after any change.