Skip to content

Conversation

@rawe0
Copy link
Member

@rawe0 rawe0 commented Nov 27, 2025

  • Adds filters depending on share type to received OCM shares
  • Deprecation of resource_type in favor of shared_resource_type, with change of type
  • Deprecation of share_type in favor of recipient_type
  • The OCMCore API remains unchanged since this is to be deprecated.

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some rephrasing in the comments

@glpatcern glpatcern changed the title OCM: Add filters on received shares OCM: Separate storage resource from shared resource and add filters on received shares Nov 27, 2025
@glpatcern glpatcern self-requested a review November 27, 2025 17:35
@glpatcern glpatcern marked this pull request as ready for review November 28, 2025 07:15
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces an important clarification and separation of concerns: an incoming OCM share may grant access to a remote resource, which does not necessarily map to a storage resource, hence the resource_type must not be a storage ResourceType.

@butonic @micbar @2403905 @aduffeck as this is a(nother) breaking change I seek your review/approval as well. We believe it is worth the effort, given the above.

@glpatcern glpatcern requested review from 2403905 and butonic November 28, 2025 07:24
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this rename as agreed, and if no comments we merge

@2403905
Copy link
Contributor

2403905 commented Dec 3, 2025

I'm ok with renaming

@rawe0 rawe0 force-pushed the decouple-ocm-share-type branch 3 times, most recently from a95bff7 to a50b244 Compare December 4, 2025 10:54
@rawe0 rawe0 force-pushed the decouple-ocm-share-type branch from a50b244 to f8fb46c Compare December 4, 2025 12:32
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rawe0 for all the reshuffling. I think this is good to go:

  • The already deprecated ocm_core_api is left untouched
  • The new types and fields are declared at the end, and corresponding old fields are flagged deprecated
    Going forward, we shall drop any deprecated field or type once we move to v1.0.0

@glpatcern glpatcern requested a review from butonic December 4, 2025 14:00
@glpatcern
Copy link
Member

@butonic any further comment on this? We'd like to merge this by end of day today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants