-
Notifications
You must be signed in to change notification settings - Fork 32
OCM: Separate storage resource from shared resource and add filters on received shares #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
glpatcern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some rephrasing in the comments
glpatcern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces an important clarification and separation of concerns: an incoming OCM share may grant access to a remote resource, which does not necessarily map to a storage resource, hence the resource_type must not be a storage ResourceType.
@butonic @micbar @2403905 @aduffeck as this is a(nother) breaking change I seek your review/approval as well. We believe it is worth the effort, given the above.
glpatcern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this rename as agreed, and if no comments we merge
|
I'm ok with renaming |
a95bff7 to
a50b244
Compare
a50b244 to
f8fb46c
Compare
glpatcern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rawe0 for all the reshuffling. I think this is good to go:
- The already deprecated
ocm_core_apiis left untouched - The new types and fields are declared at the end, and corresponding old fields are flagged
deprecated
Going forward, we shall drop any deprecated field or type once we move to v1.0.0
|
@butonic any further comment on this? We'd like to merge this by end of day today |
resource_typein favor ofshared_resource_type, with change of typeshare_typein favor ofrecipient_type