Remove <4 Python version constraint#267
Merged
csernazs merged 6 commits intocsernazs:masterfrom Oct 15, 2023
edgarrmondragon:remove-less-than-4
Merged
Remove <4 Python version constraint#267csernazs merged 6 commits intocsernazs:masterfrom edgarrmondragon:remove-less-than-4
<4 Python version constraint#267csernazs merged 6 commits intocsernazs:masterfrom
edgarrmondragon:remove-less-than-4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 4 4
Lines 597 597
=======================================
Hits 570 570
Misses 27 27 |
edgarrmondragon
commented
Oct 7, 2023
edgarrmondragon
commented
Oct 7, 2023
csernazs
requested changes
Oct 14, 2023
Owner
csernazs
left a comment
csernazs
left a comment
There was a problem hiding this comment.
sorry for being late with the review, thanks your contribution!
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| fixes: | |||
Owner
There was a problem hiding this comment.
could you remove this yaml file from your MR? I think removing python <4 constraint should not be visible to any users, or it should not cause any functionality change and I include only those to the changelog.
Contributor
Author
No worries, thanks for reviewing! |
csernazs
approved these changes
Oct 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #266