Merged
Conversation
This is a prerequisite to writing a validator-validator.
Also add a couple of extra standard rules (enum constants).
This allows a validator builder to import rules for validating its base type. Also fix issue with manifest.
This is just the first test, to prove that in a "happy path" scenario, the validator-validator can validate itself.
Oddly, I'm not being shown coverage for this test in SonarCloud.
It seems something about AppVeyor/SonarCloud getting coverage has changed or broken, so moving it to command script to try and restore it.
This uses the technique recommended by SonarCloud at https://docs.sonarcloud.io/enriching/test-coverage/dotnet-test-coverage/ It also attempts to get test results uploaded to AppVeyor.
Note that Validation has its own Parallelizable attribute, easy to mudle them up!
This removes all of the class inheritance from the Validation Manifest object model (I will do the Manifest Model later). This is done to make it easier to deal with recursive manifest items. It will now be easier to create: * Recursive collection items * Recursive polymorphic types
This moves the assembling of manifest items into a context class, rather than trying to do it inside the builders.
The validation-manifest validator needs review, because the object model has changed somewhat since it was first designed. Also, I am unaware of my current test coverage %. This commit should successfully build though.
This marks up some non-implemented functions, so SonarCloud reminds me about them, as well as fixing a minor tech issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #33 - validator can now self-validate.