Skip to content

Add integrity hashes to yarn.lock#967

Merged
kof merged 1 commit intocssinjs:masterfrom
oliviertassinari:yarn-add-integrity
Jan 1, 2019
Merged

Add integrity hashes to yarn.lock#967
kof merged 1 commit intocssinjs:masterfrom
oliviertassinari:yarn-add-integrity

Conversation

@oliviertassinari
Copy link
Contributor

@oliviertassinari oliviertassinari commented Jan 1, 2019

Field was added in yarn@1.1.0.

See yarnpkg/yarn#5042 for more information.


mui/material-ui#13055

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Jan 1, 2019

The CI fails seems unrelated to my pull-request. Could it be linked to the fact i'm using a fork? The project has a lot of branches, I find it confusing (I have just deleted some old branches to clear it a bit).

capture d ecran 2019-01-01 a 16 26 54

@kof
Copy link
Member

kof commented Jan 1, 2019

strange, I am using yarn 1.9.4, someone is using an old version, we need to make sure to enforce yarn version, otherwise it will be back and forth

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Jan 1, 2019

I have rerun the CI with no luck. It seems to be consistently failing. Did you make the BrowserStack creds public? I can help. (It's what we do with Material-UI)

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Jan 1, 2019

I have never seen any back and forth on Material-UI side, we have a lot of contributors from all range of skills. I believe yarn handle that correctly.

@HenriBeck
Copy link
Member

Yeah, it's because we don't give forks access to private env variables.

@kof kof merged commit d9c47a3 into cssinjs:master Jan 1, 2019
@oliviertassinari
Copy link
Contributor Author

Can you make them public?

@oliviertassinari oliviertassinari deleted the yarn-add-integrity branch January 1, 2019 15:41
@kof
Copy link
Member

kof commented Jan 1, 2019

that would mean everyone can access browserstack

@kof
Copy link
Member

kof commented Jan 1, 2019

those are supposed to be private

@kof
Copy link
Member

kof commented Jan 1, 2019

published v10.0.0-alpha.6

@oliviertassinari
Copy link
Contributor Author

oliviertassinari commented Jan 1, 2019

Everybody can access Material-UI BrowserStack creds. How are the other projects solving the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants