Merged
Conversation
…hub.com/csstools/postcss-plugins into fix-types--persistent-puffin-26bee81a68
romainmenke
commented
Dec 10, 2023
Member
Author
There was a problem hiding this comment.
This file is unused at this time, but I am hoping to use it to resolve : #1201
Actually running it generates hundreds of markdown files with API docs.
So I want to save that for a future PR.
Antonio-Laguna
approved these changes
Dec 15, 2023
Member
Antonio-Laguna
left a comment
There was a problem hiding this comment.
LGTM! I did a general overview as this became nasty to review!
Member
Author
I feared as much :/ Thank you for checking all this 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes : #1031
This change makes a different tradeoff.
Instead of trying to have correct types for all users and failing to do so, we could choose to only provide types for part of our users.
In practice our current typings and the entries in
package.jsonare broken.I think they only work for those who write es module syntax while configuring their TypeScript project for very old node.
I think it's better to make sure it works correctly for modern TypeScript in es modules.
I am making the assumption that those who value typings in build tools are much more likely to be also using es modules for build scripts.
Focussing on es modules, modern TypeScript and modern node has the benefit of being future proof.
The general idea remains the same :
I don't think it is needed to review this change in it's entirety, just too many generated files changed.
example change :
color-helpers: