writer-sarif: add descriptions for ShellCheck rules #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamacku
added a commit
to jamacku/differential-shellcheck
that referenced
this pull request
Apr 17, 2024
jamacku
approved these changes
Apr 17, 2024
Member
There was a problem hiding this comment.
LGTM, This is great! Thank you @lzaoral
tested in - redhat-plumbers-in-action/differential-shellcheck#371
EDIT:
For reference, this is the behavior before this PR
Member
|
@jamacku I cannot see the |
Member
|
@kdudka Yes, you have to have access to the Security dashboard of the project in order to see those links. I think you need at least write access to the repo. |
kdudka
approved these changes
Apr 17, 2024
Member
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
This indeed improves the way how GitHub renders the findings.
lzaoral
force-pushed
the
sarif-rule-description
branch
from
475a66a to
a2a4ad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.