csgrep --warning-rate-limit: drop location from key events
#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I can not speak for the correctness of the code, but I have been testing this for #187 and it works as expected. So LGTM! |
... so that `csdiff` can parse the output when processing it later on
The JSON-based output formats do not have problems with empty strings. Related: https://issues.redhat.com/browse/OSH-496
... to ease finding deduplication. If a checker is too noisy, a small change in the code could unexpectedly change the location (including the file path) of the `error[too-many]` key event, which would hamper the deduplication of findings. Related: https://issues.redhat.com/browse/OSH-496
lzaoral
approved these changes
Jun 12, 2024
Member
Author
|
@lzaoral Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to ease finding deduplication. If a checker is too noisy, a small change in the code could unexpectedly change the location (including the file path) of the
error[too-many]key event, which would hamper the deduplication of findings.Related: https://issues.redhat.com/browse/OSH-496