csgrep --file-glob: expand glob patterns #212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Oct 15, 2024
... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running `csgrep` for multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text. Related: csutils/csmock#187 Closes: csutils#212
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Oct 15, 2024
... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running `csgrep` for multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text. Related: csutils/csmock#187 Closes: csutils#212
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 15, 2024
... to avoid exceeding maximum command line length Depends-on: csutils/csdiff#212
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 15, 2024
... to avoid exceeding maximum command line length Depends-on: csutils/csdiff#212
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 15, 2024
... to avoid exceeding maximum command line length Depends-on: csutils/csdiff#212
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Oct 23, 2024
... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running `csgrep` for multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text. Related: csutils/csmock#187 Closes: csutils#212
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Oct 25, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/ added to the `fedora-41-x86_64` mock config, this can be tested using the following commands: ``` koji download-build -a src units-2.23-3.fc41 csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc ``` Depends-on: csutils/csdiff#210 Depends-on: csutils/csdiff#212 Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613 Closes: csutils#187
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 5, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/ added to the `fedora-41-x86_64` mock config, this can be tested using the following commands: ``` koji download-build -a src units-2.23-3.fc41 csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc ``` Depends-on: csutils/csdiff#210 Depends-on: csutils/csdiff#212 Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613 Closes: csutils#187
lzaoral
approved these changes
Nov 7, 2024
Member
lzaoral
left a comment
lzaoral
left a comment
There was a problem hiding this comment.
Note that I did not actually review the changes since I do not work this project any more.
... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running `csgrep` for multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text. Related: csutils/csmock#187 Closes: csutils#212
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 7, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/ added to the `fedora-41-x86_64` mock config, this can be tested using the following commands: ``` koji download-build -a src units-2.23-3.fc41 csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc ``` Depends-on: csutils/csdiff#210 Depends-on: csutils/csdiff#212 Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613 Closes: csutils#187
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 7, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/ added to the `fedora-41-x86_64` mock config, this can be tested using the following commands: ``` koji download-build -a src units-2.23-3.fc41 csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc ``` Depends-on: csutils/csdiff#210 Depends-on: csutils/csdiff#212 Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613 Closes: csutils#187
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Nov 8, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/ added to the `fedora-41-x86_64` mock config, this can be tested using the following commands: ``` koji download-build -a src units-2.23-3.fc41 csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc ``` Depends-on: csutils/csdiff#210 Depends-on: csutils/csdiff#212 Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613 Closes: csutils#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running
csgrepfor multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text.Related: csutils/csmock#187