snyk: define all findings with level error as important
#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperezdealgaba
approved these changes
Sep 27, 2023
Collaborator
jperezdealgaba
left a comment
jperezdealgaba
left a comment
There was a problem hiding this comment.
/lgtm I have been testing it and it seems fine.
Member
Author
|
@jperezdealgaba Thanks for review! |
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 9, 2024
... to 1 if `level` is `error`. This is how `csgrep ---mode=sarif` encodes the `imp` flag. As a side effect, all findings from Snyk Code with `level` set to `error` will be marked as important. Nevertheless, this is what `csmock-plugin-snyk` explicitly does already: csutils/csmock#122 Resolves: https://issues.redhat.com/browse/OSH-754 Closes: csutils#205
kdudka
added a commit
to kdudka/csdiff
that referenced
this pull request
Sep 12, 2024
... to 1 if `level` is `error`. This is how `csgrep ---mode=sarif` encodes the `imp` flag. As a side effect, all findings from Snyk Code with `level` set to `error` will be marked as important. Nevertheless, this is what `csmock-plugin-snyk` explicitly does already: csutils/csmock#122 Resolves: https://issues.redhat.com/browse/OSH-754 Closes: csutils#205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://issues.redhat.com/browse/OSH-288