results: set the "imp" flag in the list of important findings #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Apr 22, 2024
... rather than clearing it. If scan results are processed later on, it is useful to know the original state of the "imp" flag, regardless of the context (whether we have a list of important findings only, or an all-in-one list of findings). A side effect will be that a red `[important]` tag will appear in the HTML output next to each finding, which is probably harmless. Related: https://issues.redhat.com/browse/OSH-343 Related: https://issues.redhat.com/browse/OSH-565 Closes: csutils#159
hanchuntao
reviewed
Apr 26, 2024
hanchuntao
approved these changes
Apr 29, 2024
... rather than clearing it. If scan results are processed later on, it is useful to know the original state of the "imp" flag, regardless of the context (whether we have a list of important findings only, or an all-in-one list of findings). A side effect will be that a red `[important]` tag will appear in the HTML output next to each finding, which is probably harmless. Related: https://issues.redhat.com/browse/OSH-343 Related: https://issues.redhat.com/browse/OSH-565 Closes: csutils#159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... rather than clearing it. If scan results are processed later on, it is useful to know the original state of the "imp" flag, regardless of the context (whether we have a list of important findings only, or an all-in-one list of findings). A side effect will be that a red
[important]tag will appear in the HTML output next to each finding, which is probably harmless.Related: https://issues.redhat.com/browse/OSH-343
Related: https://issues.redhat.com/browse/OSH-565