Skip to content

Fix stale test names and misleading comments in tracking package #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blindndangerous wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stale test names and misleading comments in tracking package #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions internal/tracking/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,15 @@ func TestPathCheckedHookSignature(t *testing.T) {
}

func TestSoundChecker_LogicalPathsAlwaysFail(t *testing.T) {
// This test reproduces the bug: SoundChecker checks logical paths directly
// instead of resolving them through soundpack first

// Without a resolver, SoundChecker checks logical paths directly against the filesystem.
// Logical paths like "success/bash-success.wav" are never real files on disk, so they
// always return false. A resolver must be provided (via NewSoundCheckerWithResolver) to
// map logical paths to physical ones before checking existence.

var checkedPaths []string
hook := func(path string, exists bool, sequence int, context *hooks.EventContext) {
checkedPaths = append(checkedPaths, path)
// This will always be false because logical paths like "success/bash-success.wav" don't exist
// Expected: logical paths never exist on disk without a resolver
if exists {
t.Errorf("Expected path %s to not exist (logical path), but it was reported as existing", path)
}
Expand All @@ -180,9 +182,10 @@ func TestSoundChecker_LogicalPathsAlwaysFail(t *testing.T) {
}
}

// This demonstrates the bug - all logical paths fail, so fallback always goes to last level
// All logical paths fail without a resolver, confirming that NewSoundCheckerWithResolver
// is required for soundpack-aware path checking.
if len(results) > 0 && !results[len(results)-1] {
t.Log("BUG DEMONSTRATED: Even default.wav fails because we're checking logical path, not resolved path")
t.Log("Confirmed: logical paths always fail without a resolver - use NewSoundCheckerWithResolver")
}
}

Expand Down Expand Up @@ -210,8 +213,9 @@ func (m *MockSoundpackResolver) ResolveSoundWithFallback(paths []string) (string
func (m *MockSoundpackResolver) GetName() string { return "mock" }
func (m *MockSoundpackResolver) GetType() string { return "mock" }

func TestSoundChecker_WithResolver_SHOULD_FAIL(t *testing.T) {
// This test should FAIL until we implement the resolver integration
func TestSoundChecker_WithResolver(t *testing.T) {
// Verifies that NewSoundCheckerWithResolver correctly resolves logical paths to
// physical paths before checking existence on disk.

// Create temporary test files
tempDir := t.TempDir()
Expand Down