Skip to content

Conversation

@limey
Copy link
Contributor

@limey limey commented Oct 21, 2021

Description

This PR amends the example project to demonstrate the SwiftSimctl openUrl command.

A new UI test is introduced which asserts that a registered URL scheme is opened in the example app. Here is visual evidence of the test:

deeplink.test.in.example.app.mov


let exampleAppBundleId = "com.example.SwiftSimctlExample"

let simctl = SimctlClient(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to Shared.swift for convenience, plus it remains lazy as it's a global property.

@limey
Copy link
Contributor Author

limey commented Oct 28, 2021

Hi @ctreffs I've created this informal PR to showcase openUrl. Please let me know if there's anything else it needs to be considered for inclusion in the project. Thanks.

@ctreffs ctreffs self-requested a review October 28, 2021 09:29
@ctreffs ctreffs added the enhancement New feature or request label Oct 29, 2021
@ctreffs
Copy link
Owner

ctreffs commented Oct 29, 2021

Had to re-record the appearance UI tests.
Other then that: LGTM 🚀
Good work and thank you 👍

@ctreffs ctreffs merged commit 6f17358 into ctreffs:master Oct 29, 2021
@limey limey deleted the feature/add-openurl-example-test branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants