Conversation
63765e6 to
02b3bf1
Compare
|
Tacked on a commit (with a good message) doing the camelCase conversion, and converting 'var' to 'let', since 'var' is essentially deprecated now. Figured it would be better to do all the trivial formatting changes in one go. |
|
Thanks for doing this. The more that I look at it, the more I'm unsure about switching all the JS to 2-space indentation. I know that's the de facto standard pretty much everywhere now. And maybe it looks fine for someone who has been steeped in Javascript for a good long while, but I tried to give it a chance by reading the modified sections in github and also in vscode, but it's just not working for me. I find it harder to read and sadly I can use all the help I can get! I'm guessing the last section in So, I think I can accept this, with the following changes:
|
|
I am okay with the second commit but I think it should be its own PR. |
|
Oh I'm completely fine with 4-space tabs, I was just going by what was there already. I don't think there's a firm standard one way or the other. Will make the changes. |
Having a .prettierrc means anybody who uses format-on-save will automatically follow project conventions.
|
Updated! |
Having a .prettierrc means anybody who uses format-on-save will automatically follow project conventions. I used 2-space tabs because that's what you put in .editorconfig, and otherwise just left all the default settings alone.
A step further would be to add a CI job which fails if the submitter doesn’t use the formatter, but I'll let you decide if you want to go that far. I'd be happy to write the config file to make that happen.
I included a vscode config to make it more likely that future contributors do the right thing. I didn't realize until #17 that it also formats CSS, so hopefully that's OK. I can scope it down to just JS if necessary.