Skip to content

Conversation

@ovr
Copy link
Member

@ovr ovr commented Aug 25, 2022

Hello!

Thought Spot uses qtr granularity for DateTrunc function, which is the same as quarter.

Thanks

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #5159 (54f5bdd) into master (6585b08) will decrease coverage by 8.50%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #5159      +/-   ##
==========================================
- Coverage   83.10%   74.60%   -8.51%     
==========================================
  Files         130      270     +140     
  Lines       19775    31405   +11630     
  Branches        0     2918    +2918     
==========================================
+ Hits        16435    23429    +6994     
- Misses       3340     7472    +4132     
- Partials        0      504     +504     
Flag Coverage Δ
cube-backend 60.02% <ø> (?)
cubesql 83.13% <92.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/cubesql/src/compile/context.rs 1.28% <0.00%> (-0.01%) ⬇️
...t/cubesql/cubesql/src/compile/rewrite/rules/mod.rs 76.92% <ø> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/utils.rs 91.66% <91.66%> (ø)
...cubesql/cubesql/src/compile/rewrite/rules/split.rs 96.30% <94.44%> (-0.07%) ⬇️
rust/cubesql/cubesql/src/compile/mod.rs 81.17% <100.00%> (+0.08%) ⬆️
...besql/cubesql/src/compile/rewrite/rules/filters.rs 90.48% <100.00%> (ø)
...besql/cubesql/src/compile/rewrite/rules/members.rs 97.94% <100.00%> (+0.07%) ⬆️
...ubejs-schema-compiler/src/adapter/RedshiftQuery.js 25.00% <0.00%> (ø)
...-schema-compiler/src/adapter/ElasticSearchQuery.js 7.57% <0.00%> (ø)
...schema-compiler/src/compiler/DataSchemaCompiler.js 51.38% <0.00%> (ø)
... and 136 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ovr ovr force-pushed the cubesql-qrt-granularity branch from cb91a8f to 54f5bdd Compare August 25, 2022 12:51
@ovr ovr changed the title feat(cubesql): Support DateTrunc qrt for analytics queries feat(cubesql): Support DateTrunc qrt granularity for analytics queries Aug 25, 2022
@ovr ovr changed the title feat(cubesql): Support DateTrunc qrt granularity for analytics queries feat(cubesql): Support DateTrunc qtr granularity for analytics queries Aug 25, 2022
@ovr ovr marked this pull request as ready for review August 25, 2022 14:24
@ovr ovr requested a review from a team as a code owner August 25, 2022 14:24
@ovr ovr merged commit ce13846 into master Aug 25, 2022
@ovr ovr deleted the cubesql-qrt-granularity branch August 25, 2022 17:34
nayakravi pushed a commit to trueanthem/cube.js that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants