Skip to content

Conversation

@paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Oct 7, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner October 7, 2022 20:00
@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Base: 60.94% // Head: 60.94% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c6a7a90) compared to base (a8e1180).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5445   +/-   ##
=======================================
  Coverage   60.94%   60.94%           
=======================================
  Files         140      140           
  Lines       12029    12030    +1     
  Branches     2952     2953    +1     
=======================================
+ Hits         7331     7332    +1     
  Misses       4395     4395           
  Partials      303      303           
Flag Coverage Δ
cube-backend 60.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/cubejs-base-driver/src/driver.interface.ts 50.00% <ø> (ø)
...y-orchestrator/src/orchestrator/PreAggregations.ts 78.79% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov requested a review from a team as a code owner October 7, 2022 21:32
@paveltiunov paveltiunov merged commit 7726c82 into master Oct 8, 2022
@paveltiunov paveltiunov deleted the temp-tables-dropped-for-ksql branch October 8, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants