Skip to content

Make logfile name configurable #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkholz-cubert merged 1 commit into from
Jun 5, 2025
Merged

Make logfile name configurable #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions interface/cuvis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ namespace cuvis
/**
* @copydoc cuvis_init
*/
static void init(std::string const& settings_path, int global_loglevel = 4);
static void init(std::string const& settings_path, int global_loglevel = 4, std ::string logfile_name = "");
/**
* @copydoc cuvis_shutdown
*/
Expand Down Expand Up @@ -2607,9 +2607,9 @@ namespace cuvis
return std::string(version);
}

inline void General::init(std::string const& settings_path, int global_loglevel)
inline void General::init(std::string const& settings_path, int global_loglevel, std::string logfile_name)
{
chk(cuvis_init(settings_path.c_str(), global_loglevel));
chk(cuvis_init(settings_path.c_str(), global_loglevel, logfile_name.empty() ? NULL : logfile_name.c_str()));
Copy link
Contributor

@birkholz-cubert birkholz-cubert Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
chk(cuvis_init(settings_path.c_str(), global_loglevel, logfile_name.empty() ? NULL : logfile_name.c_str()));
chk(cuvis_init(settings_path.c_str(), global_loglevel, logfile_name.empty() ? nullptr : logfile_name.c_str()));

I think the cleaner c++ way would be using nullptr instead of NULL

return;
}

Expand Down