Skip to content

pass by const ref instead of pointer #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkholz-cubert merged 3 commits into from
Aug 13, 2025
Merged

pass by const ref instead of pointer #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab1324b
pass by const ref instead of pointer
birkholz-cubert Aug 13, 2025
05971b5
changed ingest_session_file to const ref
birkholz-cubert Aug 13, 2025
e6d4df7
removed nullptr check
birkholz-cubert Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions interface/cuvis.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,8 +1490,8 @@ namespace cuvis
void set_exporter(Exporter const* exporter);
void set_viewer(Viewer const* viewer);

void ingest_measurement(Measurement const* measurement);
void ingest_session_file(SessionFile const* session, std::string frame_selection);
void ingest_measurement(Measurement const& measurement);
void ingest_session_file(SessionFile const& session, std::string frame_selection);
double query_session_progress();

bool get_can_drop_results();
Expand Down Expand Up @@ -2024,12 +2024,9 @@ namespace cuvis
}
}

inline void Worker::ingest_session_file(SessionFile const* session, std::string frame_selection)
inline void Worker::ingest_session_file(SessionFile const& session, std::string frame_selection)
{
if (session != nullptr)
{
chk(cuvis_worker_ingest_session_file(*_worker, *session->_session, frame_selection.c_str()));
}
chk(cuvis_worker_ingest_session_file(*_worker, *session._session, frame_selection.c_str()));
}

inline double Worker::query_session_progress()
Expand Down Expand Up @@ -2168,7 +2165,7 @@ namespace cuvis
return {std::move(mesu), view, except};
}

inline void Worker::ingest_measurement(Measurement const* measurement) { chk(cuvis_worker_ingest_mesu(*_worker, *measurement->_mesu)); }
inline void Worker::ingest_measurement(Measurement const& measurement) { chk(cuvis_worker_ingest_mesu(*_worker, *measurement._mesu)); }

inline void Worker::start_processing() { chk(cuvis_worker_start(*_worker)); }

Expand Down