Skip to content

Conversation

@nghorbani
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds training examples for NIMA (Nima) by updating existing Jupyter notebooks and configuration settings to make them more accessible for new users. The changes focus on making the examples work out-of-the-box with simulated data and proper file path handling.

  • Updated configuration to use CPU processing instead of GPU for broader compatibility
  • Modified notebooks to include proper file existence checks and better default configurations
  • Added execution outputs and updated Python version metadata across notebooks

Reviewed Changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

File Description
settings/cuvis.settings Changed GPU processing to CPU mode for host compatibility
Example_5_Record_Video.ipynb Added file validation, camera simulation toggle, and execution outputs
Example_4_Exporters.ipynb Added file existence check and updated execution metadata
Example_1_Take_Snapshot.ipynb Enhanced with camera simulation handling and proper file validation
Comments suppressed due to low confidence (5)

Example_5_Record_Video.ipynb:1

  • Use lowercase 'f' for f-string formatting instead of uppercase 'F' for consistency with Python conventions.
{

Example_4_Exporters.ipynb:1

  • Use lowercase 'f' for f-string formatting instead of uppercase 'F' for consistency with Python conventions.
{

Example_1_Take_Snapshot.ipynb:1

  • Consider using a more user-friendly error handling approach instead of assertions, which can be disabled in production. Use explicit if statements with descriptive error messages.
{

Example_5_Record_Video.ipynb:1

  • Consider using a more user-friendly error handling approach instead of assertions, which can be disabled in production. Use explicit if statements with descriptive error messages.
{

Example_4_Exporters.ipynb:1

  • Consider using a more user-friendly error handling approach instead of assertions, which can be disabled in production. Use explicit if statements with descriptive error messages.
{

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@nghorbani nghorbani requested a review from manke-cubert October 9, 2025 07:57
Copy link
Contributor

@manke-cubert manke-cubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@manke-cubert manke-cubert merged commit 5b7e992 into feature/examples_for_training Oct 22, 2025
@birkholz-cubert birkholz-cubert deleted the feature/examples_for_training_nima branch December 22, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants