-
-
Notifications
You must be signed in to change notification settings - Fork 9
Attributing original work #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @aslakhellesoy! I'm happy to see that Serenity/JS continues to inspire :-) Would you mind attributing the original sources, please? Thanks! Jan
|
Hi @jan-molak, My primary source of inspiration from this library is the original screenplay article that you co-authored. However, I wouldn't say the library is inspired by Serenity/JS - quite the contrary :-). Serenity/JS is a much more feature-rich (and perhaps, faithful) implementation of the originally described screenplay pattern than
I'm all for giving credit where it's due though! What do you think about changing the proposed attribution to something like: |
|
Hi @aslakhellesoy, the I don't think, however, that calling an implementation without abilities, tasks, and with questions interchangeable with interactions an implementation of the "Screenplay Pattern" is accurate. Would you agree that choosing a different name for the pattern proposed here would be perhaps more appropriate and less confusing to people new to the Screenplay Pattern? It feels like the differences are substantial enough for this implementation to be its own thing. |
|
Yes, I think changing the name would be a good idea. @mattwynne, how about I also quite like Relevant tweet /cc @vincent-psarga |
|
+1 to playwright |
|
Superseded by #29 |
|
Interesting choices of attribution there Jan. To be fair, myself and Andy Palmer showed Aslak an early example of ScreenPlay (before that name had been given to the pattern – I think only to a spike I'd done) at Agile 2009... I presented it at CukeUp 2012 (that version demonstrated a "millisecond acceptance" tests type method near the end)... While Aslak and Matt may remember the more recent articles and talks – Screenplay is something they encountered via me on several occasions before over the years. In fact, I think one of the early Java examples I called screenplay4j - which now is sadly lost in an old bitbucket mercurial archive (which was the inspiration for the name in the end – despite many iterations of the name in between). I'll comment on the purity of the pattern on the other thread (#31). |
|
@antonymarcano - my impression when I studied this library was that it was a continuation of the work I did with @aslakhellesoy, @mattwynne and @jbpros in early 2017. Back then we looked into applying the Screenplay Pattern, as implemented in Serenity/JS, in acceptance tests of Cucumber Pro. Hence my original proposal. I do like how @aslakhellesoy presents the "Prior and related work" section in this latest version of the readme. While the history of the Screenplay Pattern is described in much more detail in the Serenity/JS handbook, surfacing the relevant links in the readme should make it much easier for the readers to get to the relevant sources. Do you feel the attribution section here requires any further tweaks, or are you happy with it too? |
Hi @aslakhellesoy! I'm happy to see that Serenity/JS and the Screenplay Pattern continue to inspire :-)
This commit adds attribution and links to the original sources. Hopefully, you're OK with it?
Thanks,
Jan