fix(models): declare DispatchOutbox.execution_id + cue_id FKs (parity port of cueapi/cueapi#594)#44
Closed
mikemolinet wants to merge 3 commits into
Closed
fix(models): declare DispatchOutbox.execution_id + cue_id FKs (parity port of cueapi/cueapi#594)#44mikemolinet wants to merge 3 commits into
mikemolinet wants to merge 3 commits into
Conversation
… port of cueapi/cueapi#594) Migration 002 created ``dispatch_outbox.execution_id`` with a FK to ``executions(id) ON DELETE CASCADE``. The model historically declared the column as a plain ``UUID`` without the FK. Migration 021 (messaging primitive) relaxed both ``execution_id`` and ``cue_id`` to NULLABLE for message-task rows but didn't touch the FK declarations. The drift was benign at runtime (alembic-applied production schema has the FK; `Base.metadata.create_all` test schema does not), but blocked SQLAlchemy ``relationship()`` traversal across the link and meant the test schema differed subtly from production. Both ``execution_id`` and ``cue_id`` now carry FK declarations matching migration 002's intent. ``id`` upgraded from plain ``Integer`` to ``BigInteger`` to match BIGSERIAL. New regression tests in ``tests/test_dispatch_outbox_model_drift.py`` lock in: id is BigInteger; execution_id has CASCADE FK; cue_id has CASCADE FK; both are nullable post-021. Existing outbox-cleanup fixtures in ``test_qa_observability.py`` were inserting synthetic UUIDs / cue_ids that worked only because the model omitted the FKs. Switched them to use a new ``_create_anchor_execution`` helper that creates real User + Cue + Execution rows so the FK chain is satisfied. Mirrors private's PR #594 fixture fix. Parity manifest entry for ``app/models/dispatch_outbox.py`` updated to ``last_synced: 2026-05-05`` with port reference. Tests: 657 passed, 0 regressions (7 pre-existing SDK test failures excluded — unrelated module-import errors). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Parity checkThis PR modifies files tracked in
Please confirm one of the following in a reply or PR description update:
This is a soft check — it does not block merge. The goal is visibility, not friction. See HOSTED_ONLY.md for the open-core policy. |
Collaborator
Author
|
Closing as stale — branch diverged from main by ~8880 deletions across 59 files (created pre-messaging-primitive cleanup that landed ~2026-05-01). Rebase infeasible. Feature is still needed: cueapi-core's Next step: re-port as a fresh small PR against current main HEAD (commit Branch retained for now in case the diff is useful as reference. |
auto-merge was automatically disabled
May 11, 2026 15:32
Pull request was closed
mikemolinet
added a commit
that referenced
this pull request
May 11, 2026
… port of cueapi/cueapi#594) (#75) * fix(models): declare DispatchOutbox.execution_id + cue_id FKs (parity port of cueapi/cueapi#594) The columns `execution_id` and `cue_id` on `dispatch_outbox` had no SQLAlchemy `ForeignKey()` wrapper, even though migration 002 declared the DB-level FKs to `executions.id` and `cues.id` (both with `ondelete=CASCADE`). The model omission was benign drift — the DB constraint was still enforced — but broke any future SQLAlchemy ORM `relationship()` that wanted to traverse these. Matches private cueapi's `app/models/dispatch_outbox.py` shape. ## Changes ```diff from sqlalchemy import ( - Boolean, CheckConstraint, Column, DateTime, Integer, String, Text, func, + Boolean, CheckConstraint, Column, DateTime, ForeignKey, Integer, String, Text, func, ) ... - execution_id = Column(UUID(as_uuid=True), nullable=True) - cue_id = Column(String(20), nullable=True) + execution_id = Column( + UUID(as_uuid=True), + ForeignKey("executions.id", ondelete="CASCADE"), + nullable=True, + ) + cue_id = Column( + String(20), + ForeignKey("cues.id", ondelete="CASCADE"), + nullable=True, + ) ``` ## Re-port note Re-port of closed [PR #44](#44) which was on a stale base ~8880 deletions behind current main. Same 2-3 line fix; fresh against `f9ec4ea`. ## Test plan - [x] Full local suite passes (zero regressions) - [x] DB-level FK already exists; this is a model-side declaration only - [x] Matches private cueapi shape verbatim * test(qa_observability): use anchor execution for outbox cleanup tests The 3 outbox-cleanup test fixtures inserted DispatchOutbox rows with synthetic UUID execution_ids. Once execution_id grew a ForeignKey declaration on the model (this PR's first commit), those synthetic inserts hit FK violations. Fix: introduce `_create_anchor_execution(db_session)` helper that creates a real User + Cue + Execution and returns the execution.id. Tests use that to anchor the FK; cue_id is set to NULL (these tests care about outbox lifecycle, not cue association). Same shape as private cueapi's tests/test_qa_observability.py post- FK-declaration. 6/6 outbox tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parity port of cueapi/cueapi#594 into the OSS mirror.
Migration 002 declared
dispatch_outbox.execution_idwith aForeignKey('executions.id', ondelete='CASCADE'); the model omitted it. Migration 021 relaxed bothexecution_idandcue_idto NULLABLE but didn't touch the FK declarations. The drift was benign at runtime (alembic-applied prod schema has the FK;Base.metadata.create_alltest schema does not) but blocked SQLAlchemyrelationship()traversal and meant the test schema diverged from production.This PR brings the model into agreement: both
execution_idandcue_idcarry FK declarations matching migration 002's intent.idupgraded from plainIntegertoBigIntegerto matchBIGSERIAL.Files changed
app/models/dispatch_outbox.py— declare FKs onexecution_id+cue_id; bumpidtoBigIntegertests/test_dispatch_outbox_model_drift.py— new (4 regression tests)tests/test_qa_observability.py— switch outbox-cleanup fixtures to use new_create_anchor_executionhelper (synthetic UUIDs no longer satisfy FKs)parity-manifest.json— bump dispatch_outbox entry tolast_synced: 2026-05-05Tests
657 passed locally (full suite minus 7 pre-existing SDK test failures unrelated to this PR).
Parity Impact
🤖 Generated with Claude Code