Skip to content

Recursos para card-authorizer #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pachCode merged 26 commits into from
Apr 22, 2021
Merged

Recursos para card-authorizer #146

pachCode merged 26 commits into from
Apr 22, 2021

Conversation

@chiqeen03
Copy link
Contributor

@chiqeen03 chiqeen03 commented Apr 14, 2021

Se agregan recursos para la comunicación de card-authorizer hacia knox.

  • Recurso de validación de tarjetas.
  • Recurso de validación de ARQC y generación de ARPC.

closes #144
closes #145

@chiqeen03 chiqeen03 added the enhancement New feature or request label Apr 14, 2021
@chiqeen03 chiqeen03 requested a review from matin April 14, 2021 22:15
@codecov
Copy link

codecov bot commented Apr 14, 2021 •
edited
Loading

Codecov Report

Merging #146 (764edbd) into main (0773a50) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        27    +2     
  Lines          593       652   +59     
=========================================
+ Hits           593       652   +59
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cuenca/__init__.py 100.00% <ø> (ø)
cuenca/resources/__init__.py 100.00% <100.00%> (ø)
cuenca/resources/arpc.py 100.00% <100.00%> (ø)
cuenca/resources/card_validations.py 100.00% <100.00%> (ø)
cuenca/resources/cards.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0773a50...764edbd. Read the comment docs.

@chiqeen03 chiqeen03 requested a review from rogelioLpz April 14, 2021 23:24
matin
matin reviewed Apr 20, 2021
View reviewed changes
cuenca/resources/arpc.py Outdated


@dataclass
class ARPC(Creatable):
Copy link
Member

@matin matin Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's ARPC?

Copy link
Member

@matin matin Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a description

Copy link
Member

@matin matin Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be Arpc and not ARPC. All caps is reserved for constants

matin
matin reviewed Apr 20, 2021
View reviewed changes
cuenca/resources/cards.py
funding_type: CardFundingType

@property
def last_4_digits(self):
Copy link
Member

@matin matin Apr 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to last4 instead of last_4_digits to have consistency with https://github.com/samuelcolvin/pydantic/blob/5261fd05a0374b84ce2602d45990baf480fa2417/pydantic/types.py#L854

Copy link
Contributor Author

@chiqeen03 chiqeen03 Apr 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That field is being used in Core and many other projects, I think it would be best if we created an issue and modified the field in the other projects, otherwise this change would create some PRs for other projects

Copy link
Contributor Author

@chiqeen03 chiqeen03 Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue created:
#148

@chiqeen03 chiqeen03 requested a review from matin April 20, 2021 23:54
matin
matin previously approved these changes Apr 22, 2021
View reviewed changes
@chiqeen03 chiqeen03 mentioned this pull request Apr 22, 2021
Open
rogelioLpz
rogelioLpz previously approved these changes Apr 22, 2021
View reviewed changes
@chiqeen03 chiqeen03 requested a review from rogelioLpz April 22, 2021 16:00
@pachCode pachCode merged commit 9ab94b2 into main Apr 22, 2021
@pachCode pachCode deleted the cards-validations branch April 22, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogelioLpz rogelioLpz rogelioLpz approved these changes

@matin matin matin left review comments

Assignees

@rogelioLpz rogelioLpz

@chiqeen03 chiqeen03

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agregar validación de ARQC y generación de ARPC Agregar validación de tarjetas

5 participants

@chiqeen03 @matin @rogelioLpz @pachCode